Repository navigation
Revert "Turbopack: loader change invalidation (#95732)" - #100414
Merged
Merged
Conversation
Contributor
Tests PassedCommit: b7c3ce3 |
github-actions
Bot
added
created-by: Turbopack team
lukesandberg
approved these changes
Oct 19, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
mischnic
force-pushed
the
mischnic/revert-loader-invalidation
branch
from
October 19, 2026 19:17
9bea9fa to
b7c3ce3
Compare
mischnic
added a commit
that referenced
this pull request
Oct 20, 2026
jimmyhmiller
added a commit
that referenced
this pull request
Oct 22, 2026
1. Before the rebase, we didn't have this revert #100414 this changed handled stale cached results for us in certain pnpm cases. We now need to handle these ourselves. 2. When we removed the .node special handling we exposed why it had been hacked in there to begin with. There are times where loader deps can be outside the repo like the .node for next. This made me revist the whole way we were doing errors. We won't watch those files for changes, but there is no reason to put a ton of warnings out about them 3. Test had an edge case around shutdown that would hide a failing test fixed that.
jimmyhmiller
added a commit
that referenced
this pull request
Oct 22, 2026
1. Before the rebase, we didn't have this revert #100414 this changed handled stale cached results for us in certain pnpm cases. We now need to handle these ourselves. 2. When we removed the .node special handling we exposed why it had been hacked in there to begin with. There are times where loader deps can be outside the repo like the .node for next. This made me revist the whole way we were doing errors. We won't watch those files for changes, but there is no reason to put a ton of warnings out about them 3. Test had an edge case around shutdown that would hide a failing test fixed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert part of #95732
This would cause a lot of worker pools to be created. Because
get_evaluate_pool()takes as an argument theadditional_invalidationand thus get a fresh worker pool peradditional_invalidationrelated: #100064