Repository navigation
Pass interception capability into App rendering - #100409
Merged
Merged
Conversation
Contributor
Tests PassedCommit: a4a716a |
kassens
added this pull request to stack #100411
October 19, 2026 17:16
kassens
marked this pull request as ready for review
October 19, 2026 17:27
kassens
force-pushed
the
kassens/render-interception-flag
branch
from
October 19, 2026 18:08
1cc3996 to
8cc7940
Compare
gnoff
approved these changes
Oct 19, 2026
| const couldBeIntercepted = | ||
| !!process.env.__NEXT_DEV_SERVER || | ||
| (typeof varyHeader === 'string' && varyHeader.includes(NEXT_URL)) | ||
| !!process.env.__NEXT_DEV_SERVER || ctx.couldBeIntercepted |
Contributor
There was a problem hiding this comment.
from the prior PR's feedback
should we move the dev check into the producxtion of couldBeIntercepted?
kassens
force-pushed
the
kassens/render-interception-flag
branch
2 times, most recently
from
October 19, 2026 21:01
44a8a51 to
431d6da
Compare
Base automatically changed from
kassens/render-staged-fallback-params
to
canary
October 19, 2026 21:36
kassens
force-pushed
the
kassens/render-interception-flag
branch
from
October 19, 2026 21:36
431d6da to
571d00b
Compare
kassens
force-pushed
the
kassens/render-interception-flag
branch
from
October 19, 2026 21:58
571d00b to
a4a716a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #100334 after reordering the stack. GitHub automatically marked the original PR as merged into its previous stack parent; it was not merged into canary.
Summary
Continue decoupling App Router rendering from HTTP responses: carry
couldBeInterceptedthroughRouteMatchinstead of inferring it from the response'sVaryheader while generating HTML and Flight payloads.Node supplies the existing route-matching result. The dev override and current Edge/build-time values are preserved. Adds payload assertions for interceptable and ordinary Node routes and a scoped restriction against importing
NEXT_URLback into the renderer.Verification
131 test executions passed:
test-start-turboandtest-start-webpack, including Node and Edge navigation.test-dev-turbo.__NEXT_CACHE_COMPONENTS=truedev validation viainstant-validation-static-shells(snapshot passed).test-start-webpack.