Repository navigation
test: fix flakiness in segment-cache-stale-time - #100404
Merged
Merged
Conversation
fixes flakiness introduced in #100388. route trees expire after 5min by default, so they were occasionally causing the "no-requests" assertion to fail. we can avoid this by lowering the stale-time to 4min, which still validates that the cache's stale-time is being respected. (note that this means that the cache would be excluded from app shells. however, this test suite does not currently run in PPF, and has other tests that would have the same problem, so we'll have to deal with this later anyway)
lubieowoce
added this pull request to stack #100405
October 19, 2026 17:08
Contributor
Tests PassedCommit: 0a668f3 |
github-actions
Bot
added
created-by: Next.js team
acdlite
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes flakiness introduced in #100388. route trees expire after 5min by default, so they were occasionally causing the "no-requests" assertion (which we were doing after waiting for 5min) to fail in CI.
we can avoid this by lowering the stale-time to 4min, which still validates that the cache's stale-time is being respected.
(note that this means that the cache would be excluded from app shells. however, this test suite does not currently run in PPF, and has other tests that would have the same problem, so we'll have to deal with this later anyway)