Repository navigation
lexer: combine surrogate pair escapes in string literals - #476
Merged
StevenACoffman merged 1 commit intoSep 30, 2026
Merged
Conversation
"\uD83D\uDE00" parsed as two U+FFFD. A leading surrogate escape followed by a trailing surrogate escape is now decoded as one code point, as the spec's EscapedUnicode grammar and graphql-js do. Fixes vektah#468
|
coverage: 87.492% (+0.02%) from 87.472% — Rohilalala:fix/surrogate-pair-escape into vektah:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #468.
A string literal with a surrogate pair of
\uescapes parsed as two U+FFFD:A leading surrogate escape followed by a trailing surrogate escape is now decoded as one code point, as the spec's EscapedUnicode grammar and graphql-js do.
Not changed: a lone surrogate escape still becomes U+FFFD. The current spec makes it a parse error, which I left for a separate change. The new lexer cases pin the current behaviour.
I have: