fix: html report collapse for repeated requests - #7153
Conversation
WalkthroughUpdates the Changes
Estimated code review effortðŊ 1 (Trivial) | âąïļ ~3 minutes Suggested labels
Suggested reviewers
Poem
ðĨ Pre-merge checks | â 3 | â 1â Failed checks (1 warning)
â Passed checks (3 passed)
âïļ Tip: You can configure your own custom pre-merge checks in the settings. âĻ Finishing Touchesð§Š Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
ð§đ Nitpick comments (1)
packages/bruno-common/src/runner/reports/html/template.ts (1)
763-763: Consider a cleaner separator inresultTitleto avoid ambiguity.The computed name concatenates path, status, statusText, and index with spaces. If
pathorstatusTextthemselves contain spaces, parsing the name visually (e.g., during debugging) becomes harder. A delimiter like::or__would make each segment unambiguous. Minor nit â functionality is correct.Optional refinement
- const resultTitle = computed(() => props?.result?.path + ' ' + props?.result?.response?.status + ' ' + props?.result?.response?.statusText + ' ' + props?.index); + const resultTitle = computed(() => `${props?.result?.path}::${props?.result?.response?.status}::${props?.result?.response?.statusText}::${props?.index}`);
Description
Fixes repeated requests in the HTML report all expanding/collapsing together. The collapse item name and v-for key were identical for retries of the same request, causing Naive UI to treat them as one item. Added a unique index to each entry
JIRA
Contribution Checklist:
Before
Screen.Recording.2026-02-16.at.12.53.03.PM.mov
After
Screen.Recording.2026-02-16.at.1.00.55.PM.mov
Summary by CodeRabbit
Release Notes