Skip to content

Add ISK (Icelandic Króna) to revenue currencies - #4516

Merged
mikecao merged 1 commit into
umami-software:devfrom
Alphapin:add-isk-currency
Sep 11, 2026
Merged

mikecao merged 1 commit into
umami-software:devfrom
Alphapin:add-isk-currency

Conversation

@Alphapin

@Alphapin Alphapin commented Sep 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds ISK (Icelandic Króna) to the CURRENCIES list used by the Revenue report.

Events tracked with { revenue: 12500, currency: 'ISK' } are stored correctly today, but the Revenue report can only aggregate currencies from this list, so Icelandic sites see $0.00 with no way to select ISK. One-line addition, placed with the other Nordic currencies.

Test plan

  • Track an event with currency: 'ISK', open Revenue, select "ISK — Icelandic Króna": totals appear.
  • Existing currencies unaffected.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

@Alphapin is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds Icelandic Króna (ISK) to the shared revenue currency list.

  • Makes ISK available in revenue report and board currency selectors.
  • Uses the existing revenue query and Intl.NumberFormat paths without requiring further changes.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The new ISK option flows through existing selectors, string-based revenue validation and queries, and standards-based currency formatting without requiring another allowlist or compatibility change.

Important Files Changed

Filename Overview
src/lib/constants.ts Adds a valid, unique ISK entry to the shared currency options list.

Reviews (1): Last reviewed commit: "Add ISK (Icelandic Króna) to revenue cur..." | Re-trigger Greptile

@mikecao
mikecao changed the base branch from master to dev September 11, 2026 03:24
@mikecao
mikecao merged commit 5e02155 into umami-software:dev Sep 11, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants