Repository navigation
Add ISK (Icelandic Króna) to revenue currencies - #4516
Merged
Merged
Conversation
|
@Alphapin is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryAdds Icelandic Króna (
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The new ISK option flows through existing selectors, string-based revenue validation and queries, and standards-based currency formatting without requiring another allowlist or compatibility change.
|
| Filename | Overview |
|---|---|
| src/lib/constants.ts | Adds a valid, unique ISK entry to the shared currency options list. |
Reviews (1): Last reviewed commit: "Add ISK (Icelandic Króna) to revenue cur..." | Re-trigger Greptile
mikecao
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ISK(Icelandic Króna) to theCURRENCIESlist used by the Revenue report.Events tracked with
{ revenue: 12500, currency: 'ISK' }are stored correctly today, but the Revenue report can only aggregate currencies from this list, so Icelandic sites see $0.00 with no way to select ISK. One-line addition, placed with the other Nordic currencies.Test plan
currency: 'ISK', open Revenue, select "ISK — Icelandic Króna": totals appear.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.