Repository navigation
fix(teams): respect basePath in Manage teams menu link - #4502
Merged
franciscao633 merged 1 commit intoSep 2, 2026
Merged
Conversation
|
@nicolas2601 is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR updates the âManage teamsâ menu item to use the existing programmatic navigation helpers, allowing Next.js to apply the configured base path while preserving cloud URL handling.
Confidence Score: 5/5The PR appears safe to merge, with no actionable defects identified in the changed navigation behavior. The new action preserves the existing destination while routing self-hosted navigation through Next.js so configured base paths are applied, and it retains the componentâs established cloud-mode handling.
|
| Filename | Overview |
|---|---|
| src/components/input/TeamsButton.tsx | The changed menu action follows the componentâs existing navigation pattern and introduces no actionable regression. |
Reviews (1): Last reviewed commit: "fix(teams): respect basePath in Manage t..." | Re-trigger Greptile
franciscao633
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4499
The "Manage teams" item in the teams dropdown used a raw
<a href="/settings/teams">, which bypasses the Next.js router and ignoresBASE_PATH. On subfolder deployments it pointed toexample.com/settings/teamsinstead ofexample.com/subfolder/settings/teams.Changed it to navigate through
handleNavigate(getUrl('/settings/teams')), the same pattern the team links in this menu already use.router.pushprepends the configured basePath, and cloud mode keeps working throughgetUrl.Verified with
tsc --noEmit(no new errors) andbiome linton the changed file.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.