Skip to content

fix(teams): respect basePath in Manage teams menu link - #4502

Merged
franciscao633 merged 1 commit into
umami-software:devfrom
nicolas2601:fix/manage-teams-base-path
Sep 2, 2026
Merged

franciscao633 merged 1 commit into
umami-software:devfrom
nicolas2601:fix/manage-teams-base-path

Conversation

@nicolas2601

@nicolas2601 nicolas2601 commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #4499

The "Manage teams" item in the teams dropdown used a raw <a href="/settings/teams">, which bypasses the Next.js router and ignores BASE_PATH. On subfolder deployments it pointed to example.com/settings/teams instead of example.com/subfolder/settings/teams.

Changed it to navigate through handleNavigate(getUrl('/settings/teams')), the same pattern the team links in this menu already use. router.push prepends the configured basePath, and cloud mode keeps working through getUrl.

Verified with tsc --noEmit (no new errors) and biome lint on the changed file.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

@nicolas2601 is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates the “Manage teams” menu item to use the existing programmatic navigation helpers, allowing Next.js to apply the configured base path while preserving cloud URL handling.

  • Replaces the raw anchor with a MenuItem action.
  • Preserves full-width menu-row styling after removing the anchor wrapper.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the changed navigation behavior.

The new action preserves the existing destination while routing self-hosted navigation through Next.js so configured base paths are applied, and it retains the component’s established cloud-mode handling.

Important Files Changed

Filename Overview
src/components/input/TeamsButton.tsx The changed menu action follows the component’s existing navigation pattern and introduces no actionable regression.

Reviews (1): Last reviewed commit: "fix(teams): respect basePath in Manage t..." | Re-trigger Greptile

@franciscao633
franciscao633 merged commit 2709d8e into umami-software:dev Sep 2, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants