Skip to content

Keep typed page paths selectable in reports - #4490

Merged
mikecao merged 1 commit into
umami-software:devfrom
justadityaraj:fix/page-selector-dev
Sep 6, 2026
Merged

mikecao merged 1 commit into
umami-software:devfrom
justadityaraj:fix/page-selector-dev

Conversation

@justadityaraj

@justadityaraj justadityaraj commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #4479

Problem

Report page selectors only retain values returned by the ten-result lookup. Broad searches such as / can omit the exact path, causing the ComboBox to clear a valid typed value.

Changes

Keep the current typed value in the deduplicated option list alongside the queried path and event values.

User impact

Journey and Funnel reports can select paths such as / regardless of the date range or which other paths rank in the lookup results.

Verification

  • pnpm test — 95 files and 740 tests passed
  • Focused WebsiteValueComboBox test — 2 passed
  • pnpm exec tsc --noEmit — passed
  • Biome lint and format checks on both changed files — passed
  • pnpm build with the supported database and Geo checks skipped — passed
  • Repository-wide pnpm lint still reports the existing src/app/not-found.tsx hook-name error; both changed files are clean

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@justadityaraj is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR keeps the controlled WebsiteValueComboBox value in its deduplicated options so valid typed paths remain selectable when lookup results omit them.

  • Prepends the current typed value to page and event query results.
  • Recomputes options when the controlled value changes.
  • Updates the focused test to verify that the typed value appears alongside both Journey step types.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed option construction preserves the controlled typed value while retaining the existing query-result merging and deduplication behavior, and the focused test covers the intended result.

Important Files Changed

Filename Overview
src/components/input/WebsiteValueComboBox.tsx Includes the controlled value in the deduplicated option list without introducing an established failure.
src/components/input/WebsiteValueComboBox.test.tsx Updates the combined Journey-options test to cover preservation of a typed path.

Reviews (1): Last reviewed commit: "Fix page selector custom values" | Re-trigger Greptile

@mikecao
mikecao merged commit 42c5a53 into umami-software:dev Sep 6, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants