Repository navigation
Keep typed page paths selectable in reports - #4490
Merged
Merged
Conversation
|
@justadityaraj is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR keeps the controlled WebsiteValueComboBox value in its deduplicated options so valid typed paths remain selectable when lookup results omit them.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The changed option construction preserves the controlled typed value while retaining the existing query-result merging and deduplication behavior, and the focused test covers the intended result.
|
| Filename | Overview |
|---|---|
| src/components/input/WebsiteValueComboBox.tsx | Includes the controlled value in the deduplicated option list without introducing an established failure. |
| src/components/input/WebsiteValueComboBox.test.tsx | Updates the combined Journey-options test to cover preservation of a typed path. |
Reviews (1): Last reviewed commit: "Fix page selector custom values" | Re-trigger Greptile
mikecao
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4479
Problem
Report page selectors only retain values returned by the ten-result lookup. Broad searches such as
/can omit the exact path, causing the ComboBox to clear a valid typed value.Changes
Keep the current typed value in the deduplicated option list alongside the queried path and event values.
User impact
Journey and Funnel reports can select paths such as
/regardless of the date range or which other paths rank in the lookup results.Verification
pnpm test— 95 files and 740 tests passedWebsiteValueComboBoxtest — 2 passedpnpm exec tsc --noEmit— passedpnpm buildwith the supported database and Geo checks skipped — passedpnpm lintstill reports the existingsrc/app/not-found.tsxhook-name error; both changed files are cleanNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.