Repository navigation
Fix delayed staged dock - #2569
Merged
Merged
Conversation
This adjusts commit 8aa70ef, ensuring that also secondary monitors docks are tracked, while we were potentially not tracking them anymore in case the startup animation was not already ran
It's something we always do together, so there's no point of duplicating it in multiple places
3v1n0
force-pushed
the
fix-delayed-staged-dock
branch
2 times, most recently
from
April 15, 2026 00:49
8ebbf25 to
ccd4d0f
Compare
This is something that should only happen only after the dock is staged so let's ensure this is the case
We may otherwise end up doing operations that requires a staged actor before than we can
If the actor is not visible we do not care about updating its style, also this was causing problems since commit 8aa70ef, as now the dock can be tracked (e.g. staged later), thus we do not want to set theming data while the widget it's unmapped.
Each dock destroy signal handler removes the dock from the allDocks array, but doing this while looping on it may lead to skipping elements and it's not safe. So loop over a snapshot instead. Fixes: 13ca201
3v1n0
force-pushed
the
fix-delayed-staged-dock
branch
from
April 15, 2026 01:32
57359f4 to
5d077e9
Compare
Collaborator
|
Oh it's this. |
Collaborator
|
Tested and confirmed it fixes the log spam. The rest of the changes sound reasonable but I worry a little that with so many changes we may struggle to justify them to the release team in time for 26.04. Side note: I wonder if it is now easier to fix LP#2035304... |
Collaborator
Author
Oh maybe this helps already? As we set the style before showing in theory... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details, but since 8aa70ef we may have a situation in which the dock is added to the stage later than its initialization, while various code may do operations that require the dock to be staged.
So delay all these actions until we're good to go
/cc @vanvugt
Fixes: #2565