Repository navigation
Docking: Properly disconnect various signal connections - #2568
Merged
Merged
Conversation
We were connecting (and never disconnecting) from this settings change, while we were already monitoring the key in the constructor. What we did not do, was handling the disable case though, that is now done.
We were not tracking the dock destruction events so we may have potentially accessed to destroyed dock's when iterating over them Helps with: lp:2148339
Automatically disconnect from global signal on docks destruction, and when the workspace isolation gets disabled or destroyed. LP: #2148339
We may want to ignore it once intellihide is being disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we disconnect to signals when objects may be destroyed