Skip to content

Revert "Fix Autohide Location calculation bug (Issue #2413)" - #2524

Merged
vanvugt merged 1 commit into
ubuntu:masterfrom
aleasto:autohide
Mar 5, 2026
Merged

vanvugt merged 1 commit into
ubuntu:masterfrom
aleasto:autohide

Conversation

@aleasto

@aleasto aleasto commented Mar 4, 2026 •

Copy link
Copy Markdown
Member

Clutter.Actor.get_transformed_position() accounts for animations etc... which means that it cannot be used to compute the "theoretical" global position of the dock, which indeed might be part of an animation at the moment that the method is called.

This reverts commit 3e0c24f.

Closes: #2501

Clutter.Actor.get_transformed_position() accounts for animations etc...
which means that it cannot be used to compute the "theoretical" global position
of the dock, which indeed might be part of an animation at the moment that the
method is called.

This reverts commit 3e0c24f.

Closes: ubuntu#2501
@aleasto

aleasto commented Mar 5, 2026

Copy link
Copy Markdown
Member Author

I see no evidence that 3e0c24f could possibly fix #2413
As far as I can see, both ways of getting the global position return roughly the same values, but the old one is always correct even during animations. I couldn't reproduce bug #2413 so I'm not sure what goes wrong.

@vanvugt

vanvugt commented Mar 5, 2026 •

Copy link
Copy Markdown
Collaborator

I think this is correct. The target box for intellihide should not simply slide offscreen, but should shrink to zero thickness. If it only slides offscreen then it's moving to a location where windows will never touch it and actually never trigger autohide. Remember this ClutterActorBox is defined as {x1, y1, x2, y2}, not {x, y, width, height} as the surrounding code might trick you into thinking.

Using get_transformed_position is probably also wrong because that returns stage-global coordinates (the full desktop and zero might not be the edge of the current monitor), whereas the old logic appears to be in actor-local coordinates. If you only have one monitor then you wouldn't notice that mistake.

Also, simply reverting a recent commit is safer than adding more complexity like #2519.

@vanvugt
vanvugt merged commit 0f21b6b into ubuntu:master Mar 5, 2026
1 check passed
@aslatter aslatter mentioned this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with auto hide dock (v103)

2 participants