You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FeatureFlagsDialog leaves derived grace-stamp flags in overrides when unsetting runOpsMintKind and unlocks them when toggling read-only flags #5062
hey! noticed in a7f0f90e (apps/webapp/app/components/admin/FeatureFlagsDialog.tsx) that unsetFlag(key) only deletes overrides[key] and doesn't clear derivedFlagsClearedWith(key) (runOpsMintKindPrev and runOpsMintKindFlippedAt), so unsetting runOpsMintKind leaves its effect: "derived" grace-stamp rows highlighted in the dialog and visible in Preview JSON even though they have no unset button and withMintFlipGrace deletes them on save. also noticed isLocked (!unlocked && ORG_LOCKED_FLAGS.includes(key)) unlocks effect === "derived" rows into editable inputs when checking "Unlock read-only flags", even though the v2 action strips runOpsMintKindPrev and runOpsMintKindFlippedAt from the request body.
should unsetFlag also remove derivedFlagsClearedWith(key) from overrides and keep effect === "derived" flags read-only? happy to open a quick PR if you want!
Activity