Repository navigation
Petrakeas/fix webview workaround crash - #60
Merged
n1k0sv merged 3 commits intoJan 9, 2024
Merged
Conversation
WebView layout was updated so that it can reproduce the crash that was introduced by the "Fix for Webview crash"
Changed ViewPump from 'io.github.inflationx:viewpump:2.0.3' to "dev.b3nedikt.viewpump:viewpump:4.0.14". This version has a workaround for WebViews, as it provides them with the base resources. This solves the original WebView crash and our workaround is no longer needed. Removing our workaround solves the issue where a crash occurred when a view with attributes was loaded after a WebView. The new library has very similar API to the previous one, so very few changes were required. It doesn't require wrapping the Context as the previous one. So, `TxNative#wrap()` and `TxNative#generalWarp()` now have the same implementation. The latter has now been deprecated. The new library requires wrapping the `AppCompatDeledate`, in a similar fashion that we do with our `TxContextWrappingDelegateJava`. This leaded to changes to `TxBaseAppCompatActivity`. Previously we created a new instance of `TxContextWrappingDelegateJava`, but this is no longer enough. In case a TxNative user, uses `TxContextWrappingDelegateJava` directly, `TxNative` will not work as expected after this update. To avoid a wrong configuration `TxContextWrappingDelegateJava` has been renamed to `TxContextWrappingDelegateJava2`, which will lead to a compilation error in such a case. The new ViewPump library requires AppCompat. TxNative did not require it up until now. So, some changes were necessary to move from supporting AppCompat to requiring it: * the appcompat dependency was changed from "compileOnly" to "implementation" * documentation changes
Readme was updated to reflect the following: * TxNative requires AppCompat * `generalWrap()` is deprecated and `warp()` should be used everywhere instead
n1k0sv
approved these changes
Jan 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.