Repository navigation
Support material components - #43
Merged
n1k0sv merged 1 commit intoSep 28, 2022
Merged
Conversation
Even though the SDK did not support material components, most components worked correctly since they extended vanilla Android View classes and they were handled by our TxInterceptor. `TextInputLayout` though did not work correctly. This is why we now explicitly check for this class in our `TxInterceptorand` and handle it in the `TextInputLayoutTransformer.` The following components were also tested and found to work correctly: `MaterialButton`, `MaterialCardView`. The SDK uses `material:1.6.1` as a compileOnly dependency, similarly to `appcompat`. The demo app now uses e `material:1.6.1`. The theme extends a MaterialComponents theme instead of an AppCompat theme. A TextInputLayout element has been added to the main activity's layout. The SDK's Spannable support is now enabled.
n1k0sv
approved these changes
Sep 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though the SDK did not support material components, most components worked correctly since they extended vanilla Android View classes and they were handled by our TxInterceptor.
TextInputLayoutthough did not work correctly. This is why we now explicitly check for this class in ourTxInterceptorandand handle it in theTextInputLayoutTransformer.The following components were also tested and found to work correctly:
MaterialButton,MaterialCardView.The SDK uses
material:1.6.1as a compileOnly dependency, similarly toappcompat.The demo app now uses e
material:1.6.1. The theme extends a MaterialComponents theme instead of an AppCompat theme. A TextInputLayout element has been added to the main activity's layout. The SDK's Spannable support is now enabled.