Repository navigation
textFixtures refactoring - #39
Merged
Merged
Conversation
common module has testFixtures enabled. Test code that was dubplicated between modules, is now placed in the following classes: * CDSMockHelper * TempDirHelper * StringTestData txsdk and cli modules rely on the common's testFixtures. Code was deleted and references were refactored. We used to set the following flag in the javadoc documentation: `links 'https://docs.oracle.com/javase/7/docs/api/'` This no longer works and the sitation with Java and its documentation is currently a mess. Luckily, 'https://d.android.com/reference' provides documentation for Java classes, so we can safely delete it. Gradle configuration has been modernized: * we now make use of settings.gradle * we declare application and library plugins Gradle has been updated to 7.4 AGP has been updated to 7.3 The following class renames occured: * TranslationMapStorageFilesTest -> TranslationMapStorageTest * TranslationMapStorageAndroidAssetsTest -> TranslationMapStorageAndroidTest * TxDiskTranslationsProviderTest -> TxDiskTranslationsProviderAssetsTest (under androidTest) * TxDiskTranslationsProviderTest -> TxDiskTranslationsProviderFilesTest (under test)
n1k0sv
approved these changes
Sep 23, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common module has testFixtures enabled. Test code that was dubplicated between modules, is now placed in the following classes:
txsdk and cli modules rely on the common's testFixtures. Code was deleted and references were refactored.
We used to set the following flag in the javadoc documentation:
links 'https://docs.oracle.com/javase/7/docs/api/'This no longer works and the sitation with Java and its documentation is currently a mess. Luckily, 'https://d.android.com/reference' provides documentation for Java classes, so we can safely delete it.Gradle configuration has been modernized:
Gradle has been updated to 7.4
AGP has been updated to 7.3
The following class renames occured: