Repository navigation
Petrakeas/cli special characters update - #37
Merged
n1k0sv merged 2 commits intoSep 17, 2022
Merged
Conversation
The cli tool parses the provided strings.xml files and pushes them to CDS. Before this update, it left special characters such as new lines, tabs, multiple spaces, single or double quotes etc untouched. With this update the, the behavior of Android's XML parser is followed as outlined here: https://developer.android.com/guide/topics/resources/string-resource The exact mechanics have been documented in StringXMLConverter#unescapeJavaString(). When `TxNative#setSupportSpannable()` is disabled, the SDK used to perform only these conversations: * "<" to "<" * ">" to ">" Now it also performs the following: * "&" to "&" This functionality has been moved to `Utils#unescapeHTMLEntities()` . When `TxNative#setSupportSpannable()` is enabled, it no longer passes all strings through `fromHTML()`. If the string contains no spans, it is passed through `Utils#unescapeHTMLEntities()` as usual. This is to preserve new lines and multiple spaces, which `fromHTML()` removes. The app has been updated to contain a string with HTML markup. It's not rendered stylized by default. In MyApplication.java, the setSupportSpannabled() has to be commented in. The readme has been updated to include a section regarding string styling. Unit tests have been added to cover all cases in txsdk and cli modules.
Changes have been so that the links generated for androidx are correct. Frames have also been re-enabled using the "--frames" javadoc options. Currently, this results in rendering a "frames, "no frames" toggle at the top of the documentation.
n1k0sv
approved these changes
Sep 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.