Skip to content

Adding support for Storage views to cutorch. - #158

Merged
clementfarabet merged 1 commit into
torch:masterfrom
zakattacktwitter:ztaylor/storage_view
May 27, 2015
Merged

clementfarabet merged 1 commit into
torch:masterfrom
zakattacktwitter:ztaylor/storage_view

Conversation

@zakattacktwitter

Copy link
Copy Markdown
Contributor

This is the same as torch/torch7#240 but for cutorch.

clementfarabet added a commit that referenced this pull request May 27, 2015
Adding support for Storage views to cutorch.
@clementfarabet
clementfarabet merged commit a15d6be into torch:master May 27, 2015
@dominikgrewe

Copy link
Copy Markdown
Member

I think this broke the build. You need to add view to THCudaStorage (https://github.com/torch/cutorch/blob/master/lib/THC/THCStorage.h#L12)

@dominikgrewe

Copy link
Copy Markdown
Member

And THCStorage_retain gets state as a first argument. I'm preparing a patch.

@zakattacktwitter

Copy link
Copy Markdown
Contributor Author

Thanks.

On Wed, May 27, 2015 at 10:43 AM, Dominik Grewe notifications@github.com
wrote:

And THCStorage_retain gets state as a first argument. I'm preparing a
patch.

—
Reply to this email directly or view it on GitHub
#158 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants