Skip to content

pkg: fix tso is generated even if the member is not leader (#9056) - #9193

Merged
ti-chi-bot[bot] merged 3 commits into
tikv:release-8.5from
ti-chi-bot:cherry-pick-9056-to-release-8.5
Apr 15, 2025
Merged

ti-chi-bot[bot] merged 3 commits into
tikv:release-8.5from
ti-chi-bot:cherry-pick-9056-to-release-8.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #9056

What problem does this PR solve?

Issue Number: Close #9051

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

close tikv#9051

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 14, 2025
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@rleungx This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@rleungx

rleungx commented Apr 14, 2025

Copy link
Copy Markdown
Member

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
@rleungx
rleungx force-pushed the cherry-pick-9056-to-release-8.5 branch from 96b4fd0 to f42f723 Compare April 14, 2025 07:23
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 14, 2025
@ti-chi-bot

ti-chi-bot Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: disksing, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 14, 2025
@ti-chi-bot

ti-chi-bot Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2025-04-14 07:25:42.70338142 +0000 UTC m=+2673236.387617501: ☑️ agreed by lhy1024.
  • 2025-04-14 07:29:48.933635375 +0000 UTC m=+2673482.617871466: ☑️ agreed by disksing.

@rleungx
rleungx force-pushed the cherry-pick-9056-to-release-8.5 branch from f42f723 to 0cc1c33 Compare April 14, 2025 07:38
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
rleungx force-pushed the cherry-pick-9056-to-release-8.5 branch from 0cc1c33 to 11e558f Compare April 14, 2025 08:15
@codecov

codecov Bot commented Apr 14, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (2da8160) to head (2aef77b).
Report is 2 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #9193      +/-   ##
===============================================
+ Coverage        75.58%   75.62%   +0.04%     
===============================================
  Files              462      462              
  Lines            72389    72409      +20     
===============================================
+ Hits             54715    54762      +47     
+ Misses           14176    14145      -31     
- Partials          3498     3502       +4     
Flag Coverage Δ
unittests 75.62% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 15, 2025
@ti-chi-bot
ti-chi-bot Bot merged commit a45180d into tikv:release-8.5 Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants