Skip to content

(tidb-7.5) support redact key in logs (#1612) - #1721

Merged
ti-chi-bot[bot] merged 2 commits into
tikv:tidb-7.5from
tangenta:v7.5-redact-log
Jul 23, 2025
Merged

(tidb-7.5) support redact key in logs (#1612)#1721
ti-chi-bot[bot] merged 2 commits into
tikv:tidb-7.5from
tangenta:v7.5-redact-log

Conversation

@tangenta

@tangenta tangenta commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

@tangenta
(tidb-7.5) support redact key in logs (tikv#1612)
f358c95 
Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 22, 2025
@tangenta
update integration_tests dependencies
d392e06 
Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 23, 2025
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 23, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2025

Copy link
Copy Markdown

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

you06
you06 approved these changes Jul 23, 2025
View reviewed changes

@you06 you06 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to create cherry pick in tidb-8.1 branch.

@ti-chi-bot ti-chi-bot Bot added the lgtm label Jul 23, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, ekexium, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 23, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 23, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-07-23 05:31:05.964826699 +0000 UTC m=+142622.702252910: ☑ïļ agreed by ekexium.
  • 2025-07-23 05:43:22.792680436 +0000 UTC m=+143359.530106647: ☑ïļ agreed by you06.

@ti-chi-bot
ti-chi-bot Bot merged commit 9e62374 into tikv:tidb-7.5 Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@you06 you06 you06 approved these changes
@ekexium ekexium ekexium approved these changes
+1 more reviewer
@Defined2014 Defined2014 Defined2014 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tangenta @you06 @Defined2014 @ekexium