Skip to content

manager: Rename downloaded file if exists - #3425

Merged
aviraxp merged 1 commit into
mainfrom
down
Apr 19, 2026
Merged

aviraxp merged 1 commit into
mainfrom
down

Conversation

@aviraxp

@aviraxp aviraxp commented Apr 19, 2026 •

Copy link
Copy Markdown
Collaborator

Scoped storage introduced owner package mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the download flow to avoid scoped-storage ownership conflicts by selecting a non-existing filename (renaming with an index suffix when needed) and ensures notifications reflect the resolved target name.

Changes:

  • Replace direct File(downloadsDir, fileName) target selection with resolveAvailableTarget(...) to pick an available filename.
  • Update progress and completion notifications to display the resolved target filename.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Scoped storage introduced package owner mechanism. If a user has changed
or uninstalled manager, the downloaded file's owner will be different
from current manager and violates scoped storage requirements.
@aviraxp aviraxp changed the title mananger: Rename downloaded file if exists manager: Rename downloaded file if exists Apr 19, 2026
@aviraxp
aviraxp merged commit 2e148da into main Apr 19, 2026
17 checks passed
@aviraxp
aviraxp deleted the down branch April 19, 2026 10:27
rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request Apr 19, 2026
Scoped storage introduced owner package mechanism. If a user has changed
or uninstalled manager, the downloaded file's owner will be different
from current manager and violates scoped storage requirements.

Signed-off-by: ris <rissu.ntk@gmail.com>
rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request Apr 19, 2026
Scoped storage introduced owner package mechanism. If a user has changed
or uninstalled manager, the downloaded file's owner will be different
from current manager and violates scoped storage requirements.

Signed-off-by: ris <rissu.ntk@gmail.com>
rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request Apr 19, 2026
Scoped storage introduced owner package mechanism. If a user has changed
or uninstalled manager, the downloaded file's owner will be different
from current manager and violates scoped storage requirements.

Signed-off-by: ris <rissu.ntk@gmail.com>
rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request Apr 20, 2026
Scoped storage introduced owner package mechanism. If a user has changed
or uninstalled manager, the downloaded file's owner will be different
from current manager and violates scoped storage requirements.

Signed-off-by: ris <rissu.ntk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants