Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the download flow to avoid scoped-storage ownership conflicts by selecting a non-existing filename (renaming with an index suffix when needed) and ensures notifications reflect the resolved target name.
Changes:
- Replace direct
File(downloadsDir, fileName)target selection withresolveAvailableTarget(...)to pick an available filename. - Update progress and completion notifications to display the resolved target filename.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Scoped storage introduced package owner mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements.
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Apr 19, 2026
Scoped storage introduced owner package mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements. Signed-off-by: ris <rissu.ntk@gmail.com>
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Apr 19, 2026
Scoped storage introduced owner package mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements. Signed-off-by: ris <rissu.ntk@gmail.com>
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Apr 19, 2026
Scoped storage introduced owner package mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements. Signed-off-by: ris <rissu.ntk@gmail.com>
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Apr 20, 2026
Scoped storage introduced owner package mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements. Signed-off-by: ris <rissu.ntk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scoped storage introduced owner package mechanism. If a user has changed or uninstalled manager, the downloaded file's owner will be different from current manager and violates scoped storage requirements.