Skip to content

waves: avoid calling MaxxEffect_Message before MaxxEffect_Initialize - #9882

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
barry-waves:main
Mar 11, 2025
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
barry-waves:main

Conversation

@barry-waves

Copy link
Copy Markdown
Contributor
Save the blob into the cache and ensure that MaxxEffect_Message
is not called before MaxxEffect_Initialize to avoid returning
an error code from MaxxEffect_Message.

Comment thread src/audio/module_adapter/module/waves/waves.c
    Save the blob into the cache and ensure that MaxxEffect_Message
    is not called before MaxxEffect_Initialize to avoid returning
    an error code from MaxxEffect_Message.

Signed-off-by: barry.jan <barry.jan@waves.com>
@johnylin76

Copy link
Copy Markdown
Contributor

LGTM.
BTW, I am curious of the hazard before the fix. Could this bug bring about DSP error?
It is a common case that set_configuration() may be called before prepare(). I am sure we have been done that way to Waves in previous projects, but we didn't feel something wrong.

@lgirdwood
lgirdwood merged commit 90b7f55 into thesofproject:main Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants