Skip to content

[BUG] enabling telemetry breaks shell and winconsole #9513

Closed
Closed
[BUG] enabling telemetry breaks shell and winconsole#9513
Labels
LNLApplies to Lunar Lake platformbugSomething isn't working as expected

Description

@kv2019i
kv2019i
opened on Sep 25, 2024

Describe the bug
It seems following debug features are broken on multiple Intel targets:

... it turns out this is related to enabling SOF telemetry with debug window backend in #9186 .

In theory these shouldn't conflict, shell backend is using debug window slot 0 (2.0), while winconsole is using window 3 (3.0), while telemetry is hardcoded to use 2.1.

To Reproduce
Build with above overlays.

Reproduction Rate
100% on Intel LNL.

Expected behavior
telemetry should not affect uses of other memory window users.

Impact
debug feature unavailable

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
  2. Name of the topology file
    • Topology: n/a
  3. Name of the platform(s) on which the bug is observed.
    • Platform: Intel lnl

Activity

  1. kv2019i
    added
    bugSomething isn't working as expected
    LNLApplies to Lunar Lake platform
    on Sep 25, 2024

  2. kv2019i commented on Sep 25, 2024

    @kv2019i
    kv2019i
    on Sep 25, 2024
    CollaboratorAuthor

    @tobonex @jsarha any ideas? We hit this with @ujfalusi

  3. tobonex commented on Sep 25, 2024

    @tobonex
    tobonex
    on Sep 25, 2024
    Contributor

    @kv2019i Window 3 is used by performance measurements. Try disabling CONFIG_SOF_TELEMETRY_PERFORMANCE_MEASUREMENTS to check.

  4. kv2019i commented on Sep 25, 2024

    @kv2019i
    kv2019i
    on Sep 25, 2024
    CollaboratorAuthor

    @tobonex thanks, aa, I missed this:

    #define ADSP_PMW ((volatile uint32_t *) \
»       »        (sys_cache_uncached_ptr_get((__sparse_force void __sparse_cache *) \
»       »       »       »            (WIN3_MBASE + WIN3_OFFSET))))

    So winconsole is clearly conflicting and you can use either/or.

    This doesn't explain the conflict with shell, but the shell overlay also enables the winconsole, so maybe that causes the problem.

  5. kv2019i commented on Sep 26, 2024

    @kv2019i
    kv2019i
    on Sep 26, 2024
    CollaboratorAuthor

    Closed via #9514

  6. kv2019i
    closed this as completedon Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    LNLApplies to Lunar Lake platformbugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions