Repository navigation
Add comments to entity group API - #1864
Conversation
Added comments to clarify the meanings of FourCC constants for entity group types.
|
There are a lot of other entity group types, see https://mp4ra.org/registered-types/entity-groups So just describing them here doesn't really make sense. It would be better to define constants for the 4CCs like we do for branding and just add the documentation references there. |
Added definitions for alternative image, stereo pair, and multi-resolution pyramid entity groups.
| * | ||
| * The entity group consists of multiple alternative versions, the application should display only one of them. The most preferred image comes first. | ||
| * | ||
| * See ISO/IEC 23008-12 Section 9.4.3. |
There was a problem hiding this comment.
I'm not sure these are the right references. Section 9 in ISO/IEC 23008-12:2025 (page 67) is just a pointer back to ISO/IEC 14496-12. If we're going to do this (and I think its useful), then it needs to have a revision as well as the right reference.
| * See ISO/IEC 23008-12 Section 9.4.3. | |
| * See ISO/IEC 14496-12:2026 Section 8.15.3.1. |
| * | ||
| * The entity group consists of stereoscopic pair. The first image is left image, the second image is right image. | ||
| * | ||
| * See ISO/IEC 23008-12 Section 9.4.3. |
There was a problem hiding this comment.
| * See ISO/IEC 23008-12 Section 9.4.3. | |
| * See ISO/IEC 23008-12:2025 Section 6.8.5. |
| /** | ||
| * Multi-resolution pyramid. | ||
| * | ||
| * The entity group consists of multiple resolution versions. Low resolution image comes first. |
There was a problem hiding this comment.
| * The entity group consists of multiple resolution versions. Low resolution image comes first. | |
| * The entity group consists of multiple resolution versions. Low resolution image comes first. | |
| * | |
| * See ISO/IEC 23008-12:2025/Amd. 1:2025 Section 6.8.12. |
Updated comments for entity groups and added new entity groups in ISO IEC 23008-12:2025.
bradh
left a comment
bradh
left a comment
There was a problem hiding this comment.
Could also consider stem if we're going to add ster.
| * The entity group consists of multiple alternative versions, the application should display only one of them. The most preferred image comes first. | ||
| * | ||
| * See ISO/IEC 23008-12 Section 9.4.3. | ||
| * See ISO/IEC 23008-12:2017 Section 9.4.3. |
There was a problem hiding this comment.
Use of 2017 version seems dubious here.
Fix comment indentation and trailing whitespace, correct the 'wbbr' title (white balance bracketing), fix a typo in the 'favc' description, and shorten the descriptions. Section references verified against the spec texts.
|
Thanks @torusrxxx and @bradh . I've cleaned it up a bit. |
Added comments to clarify the meanings of FourCC constants for entity group types.
I intend to add some stereo and multilayer HEVC support and APIs in the future, starting with
heif-infodumping support, then continue adding decode support with FFmpeg codec. I'm now able to dump multilayer HEIC images withheif-info. If you want to see the code now I can do a pull request.