Skip to content

Fix race with dev/delete-cluster - #1054

Merged
sjpb merged 2 commits into
mainfrom
fix/delete-race
Oct 15, 2026
Merged

Fix race with dev/delete-cluster#1054
sjpb merged 2 commits into
mainfrom
fix/delete-race

Conversation

@sjpb

@sjpb sjpb commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fix the server delete being able to return before it completes, meaning the volume or port delete fails, e.g.

$ dev/delete-cluster.py openhpc-RL8-260928-1340
server openhpc-RL8-260928-1340-479981a7 9eb876aa-8476-4e6a-b766-d6de244ebafd
volume openhpc-RL8-260928-1340-479981a7 c43cdb49-0a16-432a-8d39-cfbc80441fe6
Delete these (y/n)?:y
Deleted 1 servers
Failed to delete volume with name or ID 'c43cdb49-0a16-432a-8d39-cfbc80441fe6': Invalid volume: Volume status must be availableor error or error_restoring or error_extending or error_managing and must not be migrating, attached, belong to a group, have snapshots, awaiting a transfer, or be disassociated from snapshots after volume transfer. (HTTP 400) (Request-ID: req-6727b8fb-55a2-4671-b9ff-37687038a440)
1 of 1 volumes failed to delete.
Deleted 1 volumes

@sjpb
sjpb marked this pull request as ready for review October 1, 2026 17:08
@sjpb
sjpb requested a review from a team as a code owner October 1, 2026 17:08
elelaysh
elelaysh approved these changes Oct 12, 2026
View reviewed changes

@elelaysh elelaysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb
sjpb merged commit 4bd86f3 into main Oct 15, 2026
4 of 6 checks passed
@sjpb
sjpb deleted the fix/delete-race branch October 15, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elelaysh elelaysh elelaysh approved these changes

Assignees

No one assigned

Labels

no-imagebuild no-ticket

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjpb @elelaysh