Repository navigation
Add endpointslices.discovery.k8s.io to rbac permissions - #868
Conversation
|
Question, the #848 talks about editing Endpoint slices, this PR only adds get/list/watch, should it also have patch/update/delete @nadaverell? |
|
Good question — keep it Editing works through a different path: with auth enabled, Radar impersonates the requesting user, so the apiserver enforces their RBAC, not the ServiceAccount's. For no-auth installs where you want the SA itself to write, So this PR fully fixes #848 — once the SA can read EndpointSlices, editing them works wherever editing anything else works. Thanks for the fix! |
nadaverell
left a comment
There was a problem hiding this comment.
LGTM — thanks for catching this!
Description
Add missing permissions to get/list/watch
endpointslices.discovery.k8s.io. Seems to have been missed in #850Type of change
How has this been tested?
Adding to
additionalCrdGroupslocallyDescribe the tests you ran to verify your changes.
Error fixed:
radar 2026/06/05 14:53:52 [resource-counts] Failed to count EndpointSlice: failed to list resources: endpointslices.discovery.k8s.io is forbidden: User "system:serviceaccount:radar:radar" cannot list resource "endpointslices" in API group "discovery.k8s.io" at the cluster scopeRelated issues
Fixes #848