Skip to content

Account for the combined MCP catalog after deletion preview - #2345

Merged
nadaverell merged 1 commit into
mainfrom
fix/mcp-delete-catalog-main-20261026
Oct 27, 2026
Merged

nadaverell merged 1 commit into
mainfrom
fix/mcp-delete-catalog-main-20261026

Conversation

@nadaverell

Copy link
Copy Markdown
Contributor

Main's MCP catalog check fails after deletion confirmation and manager/pause guidance were combined: the registered descriptions and schemas total 65,281 bytes against a 64,850-byte budget.

Set the deliberately measured cap to 65,400 bytes (119 bytes of headroom). Keep every description, schema, uncertainty boundary and the 3,000-byte per-tool cap unchanged. This is a test-budget-only follow-up to merged #2041; it does not need to wait for opt-in exec in #2242.

Validation: reproduced the exact failure on current main, matching main CI; the catalog test now reports 65,281/65,400 and passes. Registered annotations, built-in Apply deletion exclusion/direct-call refusal, and confirmation-token log-redaction checks also pass. No runtime or UI behavior changed.

@nadaverell
nadaverell requested a review from hisco as a code owner October 26, 2026 18:29
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Adjust MCP catalog test budget for combined guidance

🧪 Tests 🕐 Less than 5 minutes

Grey Divider

AI Description

• Raise the MCP catalog test budget to 65,400 bytes to accommodate the measured 65,281-byte catalog.
• Preserve the 3,000-byte per-tool limit and all registered descriptions and schemas.
High-Level Assessment

Raising the measured test threshold is appropriate: it accommodates the combined catalog while retaining a small margin and the existing per-tool guard. Trimming load-bearing guidance instead would change the catalog's meaning.

Files changed (1) +2 / -2

Tests (1) +2 / -2
tools_catalog_test.goRaise the total MCP catalog test budget to 65,400 bytes +2/-2

Raise the total MCP catalog test budget to 65,400 bytes

• Adjusts the aggregate descriptions-and-schemas limit to cover the measured 65,281-byte catalog, with 119 bytes of headroom. The 3,000-byte per-tool limit and catalog contents remain unchanged.

internal/mcp/tools_catalog_test.go

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant