Repository navigation
Phone layout for the cluster Home health card - #2336
Merged
Merged
Conversation
On a phone the card's three columns stack: cluster info, then the Pods, Deployments and Nodes rings in one row of three (each ring's status lines stack under it), then resource utilization. The secondary resource row stacks and wraps. Home joins PHONE_READY_VIEWS. Desktop is unchanged: every change is behind the phone: variant.
PR Summary by QodoMake the Home cluster health card fit phone screens
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
# Conflicts: # web/src/App.tsx
# Conflicts: # web/src/App.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On a phone, the cluster Home health card's three fixed 300px columns clipped. The card now stacks:
The secondary resource row stacks and wraps. Home joins
PHONE_READY_VIEWS.Desktop
Unchanged. Every change is behind the
phone:variant. Compared against main on an EKS cluster: 0.33% at 1440px against 0.32% for main against itself (live timeline data), and within noise at 1024px.Screenshots
Radar Cloud on a GKE cluster with touch emulation. "Before" is radar main at 390px.