Repository navigation
Phone layout for Helm releases - #2331
Conversation
The app shell keeps an ~800px content floor so desktop layouts don't squeeze in narrow windows. Its content column clips horizontally, so on a phone every view was laid out at 856px and its right half was unreachable. Below 640px (the width Radar already treats as mobile) the floor no longer applies, and the views that broke without it now reflow there: - PageHeader: actions wrap under the title; the description wraps. - Issue cards: in a narrow container the title row wraps and the per-row action joins the meta line, so the title keeps the full width. - Resource detail: the header stacks (identity, then actions) and the tab-strip controls wrap under the tabs. - Helm: Name (with the namespace under it), Status and Updated. - Home cluster card: the three columns stack. - The floating update prompt spans the width and drops the shell command.
Issue rows mounted their per-row actions twice (one copy hidden by the container query). The header row now wraps instead: in a narrow container the meta chips, actions and chevron move to a line of their own under the title, so actions and chips each render once. Wide rows are unchanged. On phones the Home resource links flow and wrap instead of a fixed two columns, long Helm statuses wrap inside the badge, and the floating update prompt links to the release for package-manager installs whose command it hides.
Radar Cloud hides UpdateNotification when embedded, and this PR's scope is what the hosted app renders on phones.
âĶone layout A phone is now a narrow touch-first screen ((max-width: 639px) and (pointer: coarse)): a desktop window narrowed past 640px keeps the 800px floor and the desktop layout, and dev-tools device mode still gets the phone layout. k8s-ui exports PHONE_MEDIA_QUERY, usePhoneLayout and a phone: Tailwind variant so every surface switches on the same rule. On a phone the shell floor is 360px. Views opt into the phone layout through PHONE_READY_VIEWS; the rest keep their 800px desktop width in a container that scrolls sideways, so nothing is squeezed or clipped. The Issues, Helm and Home layouts move to their own PRs, so each view gets its own design pass; the shared page header and detail shell stay here, on the phone: variant.
On a phone the release table keeps Name (with the namespace as a sub-line) and Status; Namespace, Chart, Rev and Updated hide (they're in the release detail). Long statuses wrap inside the badge. Helm joins PHONE_READY_VIEWS. Desktop is unchanged: every change is behind the phone: variant.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
PR Summary by QodoMake Helm release triage readable on phones
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1.
|
# Conflicts: # web/src/App.tsx
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Code review by qodo was updated up to the latest commit 16a8590 |
- The Catalog toolbar (source toggle, repository or ArtifactHub filters, search, options) wraps on phones with search on its own row; it was one row wider than the screen, with no sideways scroll left once Helm opted in to the phone layout. - On a phone a sort on a hidden column (Namespace, Chart, Rev, Updated) falls back to the server's order instead of ordering the list with no visible header. - Trim two comments to the reasoning.
# Conflicts: # web/src/App.tsx
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
What
On a phone, the Helm release table keeps the two columns that matter for triage:
Namespace, Chart, Rev and Updated hide on phones; they're all in the release detail. Helm joins
PHONE_READY_VIEWS.Desktop
Unchanged. Every change is behind the
phone:variant (narrow, touch-first screens). Compared pixel by pixel against main on an EKS cluster with 23 releases: identical at 1440px, and within a refresh-icon pixel at 1024px, with the list and with a release open.Screenshots
Radar Cloud on a GKE cluster with touch emulation. "Before" is radar main at 390px.