Repository navigation
Keep relationship previews and policy metadata within caller visibility - #2083
Merged
Merged
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
nadaverell
marked this pull request as draft
October 14, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletion previews could expose resources the caller cannot read and present topology management links as guaranteed cascading deletion. Cached network-policy annotations could also retain evidence from hidden policies.
The preview checks permission to read the requested root, including case aliases such as
Secret, before traversing the cached graph. It then uses the existing per-user graph projection so only visible related resources are returned. Permission-aware bounded neighborhoods withhold policy annotations whose supporting evidence is outside the authorized traversal, and filtering copies shared maps before editing them.The dialog describes possible relationship impact. A failed request has a neutral unavailable note; a successful empty preview adds no blanket warning. Nonempty lists explain that they describe visible relationships rather than a deletion forecast. Namespace deletion explicitly warns that the namespace and its contents will be deleted, independent of topology.
The response shape and delete operation are unchanged. This PR does not classify garbage-collection ownership, propagation, finalizers or controller pruning; that remains a separate design. Review the denied-root/hidden-descendant cases and full â limited â full cache isolation.
Validation: complete application builds and TypeScript checks, focused sensitive-root handler regressions, topology/context race suites and the combined PR composition. Rendered checks cover real nonempty and Namespace previews, plus injected empty and HTTP-503 states. All dialogs were cancelled. No cluster permissions changed.
Request failure:
Successful empty preview:
Namespace deletion: