Repository navigation
Remember filters across kind and section switches - #2022
Merged
arlenvasconcelos merged 9 commits intoOct 13, 2026
Conversation
arlenvasconcelos
marked this pull request as ready for review
October 9, 2026 03:54
arlenvasconcelos
marked this pull request as draft
October 9, 2026 03:54
PR Summary by QodoRemember filters across resource kinds and section switches
AI Description
Diagram
High-Level Assessment
Files changed (12)
|
Code Review by Qodo
1. Shared links can claim filters were restored
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Switching resource kinds cleared the column and problem filters, and leaving Resources from the nav rail dropped back to a bare Pods list. Keep a per-session memory of each kind's filters and each section's last list URL, recorded from the router location so the URL stays the source of truth. A user kind switch restores that kind's filters; the rail and other section shortcuts return to the remembered list. Links that navigate with their own params, Back/Forward and URL-driven kind changes are unchanged. The namespace pick, investigation focus and drawer/detail params are never remembered. Memory lives in the app mount, so a reload or context switch forgets it and Radar Hub keeps clusters apart. The Namespace column filter gets "Apply to all sections": it sets the header namespace picker to the included values, clears the column filter once that lands, and flashes the picker. Not offered when embedded or under cache-scoped namespaces.
Session memory lost a kind's filters on reload, in a new tab, after a desktop restart and whenever Radar Hub remounted the cluster view. Keep each kind's column and problem filters in localStorage, per cluster. The URL stays the source of truth: a URL with its own list state is shown as is, and only a bare /resources/<kind> restores the saved filters, rewriting the URL with replace. The saved filters are the last ones chosen, by the user or by a link that carries filters; a restore never saves again, and a link without filters (one resource, an owner's pods, a search) leaves them alone. Clear filters removes them. Each tab keeps what it has shown, so filters chosen in another tab don't change it; localStorage only seeds a kind the first time a tab reads it. Bare /resources, which Radar Hub's rail links to, and the Resources rail item go to the last kind. Make active filters visible: Clear filters shows an accent and a count, a line says when filters were restored from the last visit, and the active filters show as removable chips above the table as well as in the empty state. A kind switch that restores filters now adds one history entry instead of two, and the URL sync also reads problem filters, so Back keeps them.
âĶst params "Apply to all sections" hands the namespace scope to the header picker. A Namespace column filter saved on another kind then narrowed or emptied that kind's list with nothing but a chip to explain it, so applying now clears the Namespace column on every kind of the cluster. Other column and problem filters stay. Section memory kept every param except a blocklist, so a param a view added later was replayed as list state: an open Application reopened when returning from the rail. Each section now keeps only the params that shape its list; anything else is dropped. Timeline keeps `time`, which the Home warnings link sets. A fresh load of bare /resources mounted the list before the last kind was known, so it landed on Pods and saved Pods as the last kind. The list now waits for the redirect. Apply to all sections is offered once the per-cluster store exists. The Resources filter params, the filters query helpers and the list route pattern each have one definition now.
arlenvasconcelos
force-pushed
the
arlen/rad-622-filter-state-across-kind-and-section-switches
branch
from
October 11, 2026 17:17
74315b8 to
393c289
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
arlenvasconcelos
marked this pull request as ready for review
October 11, 2026 21:54
|
Code review by qodo was updated up to the latest commit 393c289 |
The host's namespace picker follows ?namespaces=, which the app mirrors from the server pick, so applying the namespaces reaches it as well.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
On a kind switch the URL write ran once with the previous kind's filters before the new kind's were restored, pushing a URL with the wrong filters.
âĶ and duplicate A reload or a duplicated tab keeps the tab's own Resources filters and section memory (sessionStorage); a new tab starts from the last saved filters. Section memory is now kept per cluster instead of being cleared on context switch.
hisco
approved these changes
Oct 12, 2026
The Clear link next to "Filters restored" now resets only the kind's column and problem filters. Search, labels and the namespace pick stay. The link is always underlined so it reads as an action.
âĶstate-across-kind-and-section-switches # Conflicts: # web/src/App.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #1864.
Filters were lost when you moved around. Switching resource kinds cleared the column and problem filters. Leaving Resources and coming back through the nav rail opened a bare Pods list. A reload lost everything.
Each kind keeps its filters, per cluster
filters,problems,search,labels, owner,resource, âĶ) is shown as is. Only a bare/resources/<kind>restores the saved filters, and it writes them into the URL with replace./resourcesand the Resources rail item go to the last kind. This also covers Radar Hub's rail, which links to bare/resources.Each section returns to its last list (per tab)
viewMemory.ts). Everything else is dropped: the namespace pick, the investigation focus, drawers and details opened on top of the list (e.g. an open Application). A param a view adds later is forgotten until it is listed, never replayed by mistake.Active filters are visible
"Apply to all sections" in the Namespace column filter
?namespaces=. It is not offered with cache-scoped namespaces, where the scope is locked.Other changes
Notes
filter-statecontract used by Applications, GitOps and Checks. The per-cluster key, the URL-wins rule and the "restored" line are there so saved filters never show up unexplained.ResourcesView:rememberedKindSearch,onKindFiltersChange,onApplyNamespacesToAllSections. Hosts that don't pass them keep today's behavior. Radar Hub gets them through@skyhook-io/radar-appwith no change on its side.Type of change
How has this been tested?
Unit tests:
kindFilterStore.test.ts: per-cluster and per-group keys, tab isolation, reload / duplicated tab / new tab, unavailable storage, clearing one column on every kind.viewMemory.test.ts: the per-section allowlist, list-only routes, reload per cluster, never shared with a new tab.ResourcesView.kind-filter-memory.test.ts: restore of filters, excludes and problems.ActiveFilterBar.test.tsx.make tsc, webnpm testand the k8s-ui suite pass.By hand on a remote EKS cluster:
/resources/podsrestores the filters.radar-applinked into radar-hub-web, kind cluster): Hub chip set, Namespace filter cleared on Pods and Deployments, kept after reload.Tested locally with minikube/kind
Tested against a remote cluster
Added/updated unit tests
Checklist