Repository navigation
Environment-managed Argo CD card shows the live connection - #1761
Merged
Merged
Conversation
|
ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing |
PR Summary by QodoShow live status on environment-managed Argo CD cards
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1760, which gave the editable Argo CD pane a "Connected to Argo CD at …" line. The environment-managed card — the shape a Helm-deployed Radar shows when
RADAR_ARGOCD_TOKENprovides the token — still showed only its static summary, so on exactly the deployment where nobody can click Connect, the pane said nothing about whether the connection works.The card's read-only summary gets a Status row: "Connected at
" when the status endpoint reports a live token-backed session, "Not reachable — " when it reports why not, or "Not connected" while a reconnect is in flight. It is the one thing on that card that can change after deploy.Testing:
make tsc. Same status fields the editable pane renders (captured live on #1760); no separate capture.Note
Low Risk
UI-only change in Settings; reuses existing Argo status query fields with no API or auth changes.
Overview
The environment-managed Argo CD settings card (Helm /
RADAR_ARGOCD_TOKEN) now surfaces live connection status, matching the editable pane from #1760.ArgoCDEnvManagedFieldreceivesconnectedAddressandstatusReasonfrom the existinguseArgoStatuswiring and adds a Status row: green “Connected at …”, warning “Not reachable — …”, or “Not connected” while status is pending. Server/token/TLS stay static; status is the only field that can update after deploy without editing settings.Reviewed by Cursor Bugbot for commit b6e2071. Bugbot is set up for automated code reviews on this repo. Configure here.