Skip to content

Environment-managed Argo CD card shows the live connection - #1761

Merged
nadaverell merged 1 commit into
mainfrom
polish/argo-env-card-status
Sep 14, 2026
Merged

nadaverell merged 1 commit into
mainfrom
polish/argo-env-card-status

Conversation

@nadaverell

@nadaverell nadaverell commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #1760, which gave the editable Argo CD pane a "Connected to Argo CD at …" line. The environment-managed card — the shape a Helm-deployed Radar shows when RADAR_ARGOCD_TOKEN provides the token — still showed only its static summary, so on exactly the deployment where nobody can click Connect, the pane said nothing about whether the connection works.

The card's read-only summary gets a Status row: "Connected at

" when the status endpoint reports a live token-backed session, "Not reachable — " when it reports why not, or "Not connected" while a reconnect is in flight. It is the one thing on that card that can change after deploy.

Testing: make tsc. Same status fields the editable pane renders (captured live on #1760); no separate capture.


Note

Low Risk
UI-only change in Settings; reuses existing Argo status query fields with no API or auth changes.

Overview
The environment-managed Argo CD settings card (Helm / RADAR_ARGOCD_TOKEN) now surfaces live connection status, matching the editable pane from #1760.

ArgoCDEnvManagedField receives connectedAddress and statusReason from the existing useArgoStatus wiring and adds a Status row: green “Connected at …”, warning “Not reachable — …”, or “Not connected” while status is pending. Server/token/TLS stay static; status is the only field that can update after deploy without editing settings.

Reviewed by Cursor Bugbot for commit b6e2071. Bugbot is set up for automated code reviews on this repo. Configure here.

@nadaverell
nadaverell requested a review from hisco as a code owner September 14, 2026 14:13
@qodo-code-review

Copy link
Copy Markdown

ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Show live status on environment-managed Argo CD cards

✨ Enhancement 🕐 Less than 10 minutes

Grey Divider

AI Description

• Shows live connection status on environment-managed Argo CD cards.
• Distinguishes connected addresses, unreachable reasons, and transient disconnected states.
• Reuses existing status data without changing read-only configuration behavior.
Diagram

graph TD
  API["Status endpoint"] --> Settings["Settings dialog"] --> Card["Managed Argo card"] --> State{"Connection state"}
  State -->|Address| Connected["Connected address"]
  State -->|Reason| Unreachable["Failure reason"]
  State -->|Neither| Disconnected["Not connected"]
Loading
High-Level Assessment

The current approach is optimal: it forwards status data already fetched by the settings dialog and renders it directly in the read-only card. A separate status request would duplicate polling and state, while extracting shared status UI would add abstraction for a small, context-specific presentation.

Files changed (1) +23 / -1

Enhancement (1) +23 / -1
SettingsDialog.tsxDisplay live status on the environment-managed Argo CD card +23/-1

Display live status on the environment-managed Argo CD card

• Forwards the existing connected address and status reason into the read-only Argo CD field. Adds a Status row showing the connected endpoint, an unreachable reason, or a neutral not-connected state.

web/src/components/settings/SettingsDialog.tsx

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@nadaverell
nadaverell merged commit 3988827 into main Sep 14, 2026
9 checks passed
@nadaverell
nadaverell deleted the polish/argo-env-card-status branch September 14, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant