Repository navigation
[HiSparse] fix: reject speculative decoding and mixed chunk at startup - #41347
Merged
ispobock merged 2 commits intoOct 1, 2026
Merged
Conversation
This was referenced Sep 26, 2026
Collaborator
Author
|
/tag-and-rerun-ci |
ispobock
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
validate_hisparseaccepts two combinations that crash the scheduler on the first request:HiSparseDSATokenToKVPoolnever gets a HiSparse mapping registered, so the first draft extend dies intranslate_loc_to_hisparse_device:AttributeError: 'HiSparseDSATokenToKVPool' object has no attribute 'full_to_hisparse_device_index_mapping'.--enable-mixed-chunk+ HiSparse. Mixing a prefill into the HiSparse decode batch fails inmerge_batch:TypeError: can only concatenate list (not "NoneType") to list.Both were reproduced on a 4-layer DeepSeek-V3.2 config with dummy weights (one H200, greedy,
--disable-radix-cache). The control arms are identical to each other, so each crash is specific to the combination:Modifications
Reject both at startup with a clear error, until HiSparse supports them (speculative decoding is in progress in #40670 / #37771, which can drop the check).
Accuracy Tests
ValueError: --enable-hisparse does not support speculative decoding yet.test_server_args.py,test_model_overrides.py: 385 passed.Checklist
CI States
Latest PR Test (Base): ✅ Run #36293131226
Latest PR Test (Extra): ❌ Run #36293131028
Latest PR Test (AMD ROCm 10): ❌ Run #36293131140