Repository navigation
[Fix] Run KV canary hooks for context-parallel prefill - #40642
Merged
Merged
Conversation
Collaborator
Author
|
/rerun-test test_e2e_cp.py |
Contributor
|
Results for 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP prefill calls the transformer body directly and bypasses the outer
model.forwardpatched by KV canary. This skips the canary pre/post hooks and triggersSimplePhaseChecker: phase mismatch(expect=3,actual=1) in bothlogandraisemodes.When prefill CP is enabled, also wrap the transformer body's forward with the existing canary hooks. The shared bracket scope keeps decode, which still enters through the outer model, from running those hooks twice. Add a CP=2 regression covering prefill followed by CUDA-graph decode in
raisemode with real-KV hashing enabled. The registered test starts the server once;loguses the same hook path and was checked separately.Validation on two H200 GPUs:
66f19f5c46; the same four-request smoke passes with this fix.test/registered/mock_model/test_e2e_cp.py: passed in 46.5 seconds (down from 93.1 seconds for two launches), with token-oracle input checking and--kv-canary-real-data all. A separatelogsmoke also passed; CI retains onlyraiseto avoid repeating server startup.log, real-KV hashing, and verify-token assertions, including repeated prompts that reuse the prefix cache.CI States
Latest PR Test (Base): ❌ Run #35664946928
Latest PR Test (Extra): ❌ Run #35664946646
Latest PR Test (AMD ROCm 10): ❌ Run #35664947008