Repository navigation
model: support EmbeddingGemma - #32375
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mickqian
force-pushed
the
agent/support-embeddinggemma-bcg
branch
2 times, most recently
from
July 25, 2026 03:07
af2093d to
27108bb
Compare
mickqian
force-pushed
the
agent/support-embeddinggemma-bcg
branch
from
July 25, 2026 03:11
27108bb to
e4252b5
Compare
mickqian
marked this pull request as ready for review
July 25, 2026 05:35
mickqian
requested review from
Ying1123,
b8zhong,
hnyls2002 and
merrymercy
as code owners
July 25, 2026 05:35
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mickqian
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Qiaolin-Yu,
ch-wan,
hebiao064,
ispobock and
xiezhq-hermann
as code owners
July 25, 2026 05:35
Collaborator
Author
|
/tag-and-rerun-ci |
mickqian
changed the title
cuda_graph_config.prefill.max_bs is Optional[int] and defaults to None when the phase config is built without an explicit value, so the `max_bs <= 0` check raised `TypeError: '<=' not supported between instances of 'NoneType' and 'int'`. Treat None as unset (same as <= 0) using the existing `max_bs or 0` idiom. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkruff check --ignore F722,F841on the changed Python and test filespytestcollection could not run in the current local environment because its Python dependencies are incomplete/incompatible (msgspecis missing and the global Hugging Face Hub package is incompatible with this checkout).CI States
Latest PR Test (Base): 🚫 Run #30183386286
Latest PR Test (Extra): ✅ Run #30231131067