Repository navigation
Revert "Fix mamba track-boundary seqlen under overlap scheduler (#31369)" - #31622
Merged
Merged
Conversation
…)" This reverts commit 0675d30.
alisonshao
requested review from
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
July 17, 2026 23:09
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/rerun-test test_qwen3_next_models.py |
Contributor
|
Results for 🚀 |
Collaborator
Author
|
/rerun-test test/registered/models_e2e/test_qwen3_next_models.py |
Contributor
|
Results for 🚀 |
Collaborator
Author
|
Hardware-confirmed the A/B on 4-gpu-h100 (CI):
So #31369 is confirmed as the regressor and this revert restores the passing behavior. The original overlap-scheduler boundary fix should re-land via #29792. |
Zhylkaaa
pushed a commit
to Zhylkaaa/sglang
that referenced
this pull request
Jul 29, 2026
2 tasks done
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reverts #31369, which introduced a deterministic correctness regression on
main: the Qwen3-Next decode-cache-hit logprobs diverge from a cold recompute, failing the nightly4-gpu-h100test since 2026-07-17:(identical kl_div on every retry → deterministic, not flaky).
Bisect
Pinned to #31369 (
0675d3033f):dc0b3eband jumped to 0.0065 (fail) at681c2235; Fix mamba track-boundary seqlen under overlap scheduler #31369 is absent in the good run, present in the bad run._mamba_check_track_boundary/batch_result_processor.py/ the mamba track-boundary logic.Why it regressed
#31369 changed the boundary seqlen from
req.kv_committed_lentolen(req.origin_input_ids) + len(req.output_ids) - 1. That new seqlen mislabels the mamba track boundary for the decode-cache-hit case, so a reused/donated tracked prefix extends from a state a cold prefill recompute would not produce — exactly the mismatch the test catches (and the symptom #31369's own description warns about).Scope
Reverting restores the previously-passing behavior. The original overlap-scheduler boundary issue #31369 aimed at should re-land through the open #29792 ("Fix Mamba track-boundary bookkeeping under overlap scheduling"), which targets the same code with the correct bookkeeping.
Hardware A/B confirmation (revert → kl_div back under threshold) on a 4×H100 devbox is in progress; will update this PR with the before/after numbers.
CI States
Latest PR Test (Base): ❌ Run #29619940928
Latest PR Test (Extra): ❌ Run #29619940825