Repository navigation
[Spec] Rename num_tokens_per_bs to num_tokens_per_req - #30977
Merged
Merged
Conversation
hnyls2002
requested review from
Fridge003,
HaiShaw,
Qiaolin-Yu,
Ying1123,
hebiao064,
iforgetmyname,
ispobock,
jybsuper,
kpham-sgl,
lifuhuang,
merrymercy,
ping1jing2,
pyc96,
whybeyoung and
yushengsu-thu
as code owners
July 13, 2026 05:30
github-actions
Bot
added
lora
deepseek
speculative-decoding
blackwell
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
hnyls2002
requested review from
JustinTong0323,
sogalin and
zijiexia
as code owners
July 13, 2026 08:08
github-actions
Bot
added
the
documentation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
AliceChenyy
added a commit
to AliceChenyy/sglang
that referenced
this pull request
Jul 14, 2026
Conflicts resolved: - decode_cuda_graph_runner.py: kept the PP-proxy input-buffer refresh, adopted upstream's is_dflash_family()/is_ragged condition (sgl-project#30261), and renamed num_tokens_per_bs -> num_tokens_per_req in the PP proxy output slice (sgl-project#30977). - eagle_worker_v2.py: dropped the local _get_plan_stream (extracted to a shared get_plan_stream upstream, sgl-project#31008/sgl-project#30857) and re-applied the pp_proxy_tensors parameter on the deduplicated forward_batch_generation signature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical rename (227 occurrences, 36 files): the value is the token count per request slot, not per batch — every use multiplies it by the request count, and
EagleVerifyInput.num_tokens_per_reqalready uses the correct name for the same quantity. No behavior change; verified byte-identical toHEAD+ textual substitution (plus one black line-wrap).CI States
Latest PR Test (Base): 🚫 Run #29234563363
Latest PR Test (Extra): ❌ Run #29234563183