Repository navigation
[CI] Refactor int checkpoint tests style - #28813
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request registers CPU unit tests for the int8 checkpoint store to run on the cheapest CI tier (base-a-test-cpu) and moves the end-to-end GPU test (test_int8_mamba_checkpoint_e2e) from the base-c stage to the extra-b stage. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
5 tasks
yuan-luo
added
ci
Collaborator
Author
|
/tag-and-rerun-ci |
yuan-luo
force-pushed
the
fix-ci-style
branch
2 times, most recently
from
June 22, 2026 05:59
ca38fda to
fc7930b
Compare
…e to extra Addresses review comments on sgl-project#28185: - test/srt is deprecated: move test_int8_checkpoint_store.py to test/registered/mem_cache/ and register it on the cheapest tier (register_cpu_ci, base-a-test-cpu). It is an automated unit test, not a manual one; the lone CUDA decode-error case self-skips on CPU runners and its GPU path is covered by the e2e test. - don't waste 400s in base CI: move test_int8_mamba_checkpoint_e2e.py from base-c to extra-b (4-gpu-h100), so it only runs under the run-ci-extra label instead of on every PR.
Chronostasys
pushed a commit
to MindLab-Research/sglang
that referenced
this pull request
Aug 24, 2026
Co-authored-by: luoyuan.luo <luoyuan.luo@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relocate int8 checkpoint tests off deprecated test/srt + move e2e to extra
Addresses review comments on #28185:
test/srt is deprecated: move test_int8_checkpoint_store.py to test/registered/mem_cache/ and register it on the cheapest tier (register_cpu_ci, base-a-test-cpu). It is an automated unit test, not a manual one; the lone CUDA decode-error case self-skips on CPU runners and its GPU path is covered by the e2e test.
don't waste 400s in base CI: move test_int8_mamba_checkpoint_e2e.py from base-c to extra-b (4-gpu-h100), so it only runs under the run-ci-extra label instead of on every PR.
Motivation
Modifications
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #27934039287
Latest PR Test (Extra): ✅ Run #27934039051