Repository navigation
Check copyright - #230
Check copyright#230
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces automated tooling and updated documentation to ensure all Go source files within the repository adhere to the Apache 2.0 copyright header standard. It provides developers with new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces helpful tooling for checking and adding copyright headers to Go files, along with corresponding documentation updates. The changes are well-structured. My review provides suggestions to improve the robustness of the argument parsing in the new shell scripts to make them more user-friendly.
There was a problem hiding this comment.
Pull request overview
Adds tooling and CI to ensure changed Go files in PRs include a standard Apache 2.0 copyright header, plus make targets and docs pointing contributors to the workflow.
Changes:
- Add scripts to check/fix copyright headers on Go files changed against a base ref.
- Add Makefile targets and contributor docs for running the checks locally.
- Add a GitHub Actions workflow to run the check on PRs and pushes to
main.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/check-copyright-on-pr-go-files.sh | New script to detect missing headers in changed Go files. |
| tools/add-copyright-to-pr-go-files.sh | New script to automatically insert the Apache 2.0 header into changed Go files. |
| Makefile | Adds make copyright-check / make copyright-fix targets. |
| .github/workflows/copyright-check.yml | Adds CI job to run the header check on PRs/pushes. |
| README.md | Documents the new make targets for contributors. |
| CONTRIBUTING.md | Adds guidance for Go PRs to run/check/fix headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.