Skip to content

fix: generated manifests missing latest CRD - #222

Merged
cheyang merged 1 commit into
sgl-project:mainfrom
Syspretor:fix/manifest-missing-latest-crds
Mar 18, 2026
Merged

cheyang merged 1 commit into
sgl-project:mainfrom
Syspretor:fix/manifest-missing-latest-crds

Conversation

@Syspretor

Copy link
Copy Markdown
Collaborator

Ⅰ. Motivation

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where generated manifests were missing the latest Custom Resource Definitions. The change ensures that the release script correctly identifies and incorporates the most current CRDs by updating the source directory to the authoritative config/crd/bases path, thereby preventing outdated resource definitions in deployments.

Highlights

  • CRD Source Path Update: The script tools/release/update-release.sh has been updated to source Custom Resource Definitions (CRDs) from the config/crd/bases directory, which is now considered the authoritative source, instead of the previous HELM_CHART_PATH/crds.
  • Improved CRD Processing Robustness: A warning message has been added to tools/release/update-release.sh to notify users if the specified CRD base directory (config/crd/bases) is not found, ensuring better feedback during manifest generation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the source of Custom Resource Definitions (CRDs) used when generating release manifests, ensuring the latest versions are included. The change updates the release script to pull CRDs from config/crd/bases, which is the authoritative source. My review includes suggestions to improve the shell script's robustness by using shopt -s nullglob for safer file iteration and redirecting warning messages to stderr, aligning with shell scripting best practices.

Comment thread tools/release/update-release.sh
Comment thread tools/release/update-release.sh

@cheyang cheyang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang
cheyang merged commit 6b26b6c into sgl-project:main Mar 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants