Skip to content

Change version of Makefile to 0.7.0 - #215

Merged
cheyang merged 1 commit into
sgl-project:mainfrom
cheyang:update_0.7.0
Mar 17, 2026
Merged

cheyang merged 1 commit into
sgl-project:mainfrom
cheyang:update_0.7.0

Conversation

@cheyang

@cheyang cheyang commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Ⅰ. Motivation

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

Signed-off-by: cheyang <cheyang@163.com>
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's semantic version in the Makefile. This change ensures that all subsequent builds and releases will correctly reflect the new v0.7.0 version, aligning the project's build configuration with its current development cycle.

Highlights

  • Project Version Update: Updated the VERSION variable in the Makefile from v0.6.0 to v0.7.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Makefile
    • Updated the VERSION variable from v0.6.0 to v0.7.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@RongGu
RongGu enabled auto-merge (squash) March 17, 2026 07:39
@RongGu
RongGu disabled auto-merge March 17, 2026 07:39
@RongGu
RongGu enabled auto-merge (squash) March 17, 2026 07:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version in the Makefile. My review identifies that this version bump is incomplete, as the corresponding version in the Helm chart has not been updated. This could lead to inconsistencies in deployment. Please see the detailed comment.

Comment thread Makefile
BENCHMARK_TOOL_GENAI_DOCKERFILE ?= tools/benchmark/genai/Dockerfile

VERSION ?= v0.6.0
VERSION ?= v0.7.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Updating the version in the Makefile is correct, but for a complete version bump, other files need to be updated as well. The Helm chart at deploy/helm/rbgs/Chart.yaml still specifies version 0.6.0. Please update the version and appVersion fields in deploy/helm/rbgs/Chart.yaml to 0.7.0 to ensure consistency.

@Syspretor Syspretor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang
cheyang disabled auto-merge March 17, 2026 08:34
@cheyang
cheyang merged commit f8803e1 into sgl-project:main Mar 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants