Skip to content

fix: add explicit permissions to the docs-check workflow - #105

Merged
RongGu merged 2 commits into
sgl-project:mainfrom
Phil-Fan:main
Nov 19, 2025
Merged

RongGu merged 2 commits into
sgl-project:mainfrom
Phil-Fan:main

Conversation

@Phil-Fan

Copy link
Copy Markdown
Contributor

Ⅰ. Motivation

Add an explicit permissions block with minimally required privileges

Ⅱ. Modifications

add permission to .github/workflows/docs-check.yml

Ⅲ. Does this pull request fix one issue?

fix #103

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an explicit permissions block to the docs-check workflow to follow security best practices by specifying minimal required privileges. This aligns with the principle of least privilege for GitHub Actions workflows.

  • Added permissions block with contents: read permission to the docs-check workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/docs-check.yml Outdated
@cheyang

cheyang commented Nov 18, 2025

Copy link
Copy Markdown
Collaborator

@Phil-Fan Thanks so much for your helpful contributions! If possible, could you please share your email address? I'd love to get in touch.

@Phil-Fan

Copy link
Copy Markdown
Contributor Author

sure, my email address is hw.phil.fan@gmail.com

@RongGu

RongGu commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

@Phil-Fan Please fix the comment from copilot. Thanks.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@RongGu RongGu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@RongGu
RongGu merged commit fe66f4f into sgl-project:main Nov 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Add explicit permissions to the docs-check workflow

5 participants