Skip to content

Don't lookahead from interpolation - #25834

Merged
som-snytt merged 1 commit into
scala:mainfrom
som-snytt:issue/25717-interpol-assert
Apr 20, 2026
Merged

Don't lookahead from interpolation#25834
som-snytt merged 1 commit into
scala:mainfrom
som-snytt:issue/25717-interpol-assert

Conversation

@som-snytt

Copy link
Copy Markdown
Contributor

Fixes #25717

Verified manually that other usages of lookahead check the current in.token first.

How much have you relied on LLM-based tools in this contribution?

Not at all

How was the solution tested?

New automated tests (including the issue's reproducer, if applicable)

@som-snytt
som-snytt marked this pull request as ready for review April 17, 2026 07:18
@Gedochao Gedochao assigned Gedochao and warcholjakub and unassigned Gedochao Apr 17, 2026

@warcholjakub warcholjakub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@som-snytt
som-snytt merged commit 2c89135 into scala:main Apr 20, 2026
45 checks passed
@som-snytt
som-snytt deleted the issue/25717-interpol-assert branch April 20, 2026 12:41
mbovel pushed a commit to mbovel/dotty that referenced this pull request May 4, 2026
Fixes scala#25717 

Verified manually that other usages of `lookahead` check the current
`in.token` first.
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 10, 2026
@WojciechMazur WojciechMazur added this to the 3.8.4 milestone May 10, 2026
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels May 10, 2026
WojciechMazur added a commit that referenced this pull request May 11, 2026
Backports #25834 to the 3.8.4-RC2.

PR submitted by the release tooling.
tgodzik pushed a commit that referenced this pull request May 26, 2026
Fixes #25717 

Verified manually that other usages of `lookahead` check the current
`in.token` first.
[Cherry-picked 2c89135]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jun 1, 2026
bishabosha pushed a commit to dotty-staging/dotty that referenced this pull request Jun 5, 2026
Fixes scala#25717 

Verified manually that other usages of `lookahead` check the current
`in.token` first.
alexarchambault pushed a commit to plasmon-scala/scala3 that referenced this pull request Jun 16, 2026
Fixes scala#25717 

Verified manually that other usages of `lookahead` check the current
`in.token` first.
[Cherry-picked 2c89135]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:done This PR was successfully backported.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError during lexical analysis of a macro definition

5 participants