Skip to content

Move process parse exceptions to sys.error instead of a custom exception - #25675

Merged
SolalPirelli merged 1 commit into
scala:mainfrom
dotty-staging:s/m8
Apr 1, 2026
Merged

Move process parse exceptions to sys.error instead of a custom exception#25675
SolalPirelli merged 1 commit into
scala:mainfrom
dotty-staging:s/m8

Conversation

@SolalPirelli

@SolalPirelli SolalPirelli commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Having a custom private exception, that thus can't be caught externally aside from RuntimeException anyway, is weird.

How much have you relied on LLM-based tools in this contribution?

not

How was the solution tested?

new tests

@SolalPirelli
SolalPirelli requested a review from a team as a code owner April 1, 2026 13:09
tgodzik
tgodzik approved these changes Apr 1, 2026
View reviewed changes

@tgodzik tgodzik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SolalPirelli
SolalPirelli merged commit 2f82225 into scala:main Apr 1, 2026
64 checks passed
@SolalPirelli
SolalPirelli deleted the s/m8 branch April 1, 2026 15:08
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label May 10, 2026
@WojciechMazur WojciechMazur added this to the 3.8.4 milestone May 10, 2026
@WojciechMazur WojciechMazur mentioned this pull request May 10, 2026
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels May 10, 2026
@som-snytt

som-snytt commented May 11, 2026

Copy link
Copy Markdown
Contributor

Too late to object, but

thus can't be caught externally

implies it may be useful internally.

Also, even if it's not intended for external consumption, seeing its name in a stack trace is useful.

I thought scala.sys was slated for some sort of demolition. but maybe that was only sys.process.

WojciechMazur added a commit that referenced this pull request May 11, 2026
@WojciechMazur
Backport "Move process parse exceptions to sys.error instead of a cusâ€Ķ
8781bf0 
â€Ķtom exception" to 3.8.4 (#26039)

Backports #25675 to the 3.8.4-RC2.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels May 11, 2026
alexarchambault pushed a commit to plasmon-scala/scala3 that referenced this pull request Jun 16, 2026
@SolalPirelli @WojciechMazur
Move process parse exceptions to sys.error instead of a custom exceptâ€Ķ
6fe1e9d 
â€Ķion (scala#25675)

Having a custom private exception, that thus can't be caught externally
aside from RuntimeException anyway, is weird.

## How much have you relied on LLM-based tools in this contribution?

not

## How was the solution tested?

new tests
[Cherry-picked 2f82225]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.4

Development

Successfully merging this pull request may close these issues.

4 participants

@SolalPirelli @som-snytt @tgodzik @WojciechMazur