preserve span of this during statification of trait constructors - #25354
Merged
Conversation
In the backend, trait constructors are modified to become static methods that are taking the `this` as the first parameters. when updating the body of the constructor, we also change the `This` tree to a reference to the newly added parameter which will have the effect of swaitching the span of that definition. As such, we preserve the span of the `This` by copying it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the backend, trait constructors are modified to become static methods that are taking the
thisas the first parameters. When updating the body of the constructor, we also change theThistree to a reference to the newly added parameter which will have the effect of switching the span to that definition. As such, we preserve the span of theThisby copying it.Closes #23413