Fix #25342: Transfer methodsAllowingJSAwait to forcefully inlined methods. - #25344
Merged
sjrd merged 1 commit intoFeb 25, 2026
Merged
Conversation
âĶned methods.
Member
Author
|
Review by @natsukagami, since you reviewed the original PR that added this code? It's a tiny fix. |
natsukagami
approved these changes
Feb 25, 2026
natsukagami
left a comment
natsukagami
left a comment
Contributor
There was a problem hiding this comment.
It makes sense to me but I might not have the full context ð I do have a question on the test though, just so that we confirm that it resolves the issue correctly
| def unitAsyncBlock_Issue25342(): AsyncResult = await { | ||
| val buf = new ArrayBuffer[String]() | ||
|
|
||
| val px = js.Promise.resolve[Int](5) |
Contributor
There was a problem hiding this comment.
I wonder if you should use a Promise[Unit] in this test to align with #25342?
Member
Author
There was a problem hiding this comment.
The problem was not the type of the js.await. It was the fact that js.async was of type Unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was done entirely by a human (obviously).