Scoverage: do not instrument erased values. - #25298
Merged
Merged
Conversation
anatoliykmetyuk
force-pushed
the
scoverage-erasure
branch
3 times, most recently
from
February 18, 2026 16:52
0257789 to
5a58094
Compare
Otherwise, during erasure phase, they will be impure and emit an error. Purity constraint is needed in the context of capabilities, which are erased and can only be pure values. Enable related ignored tests. Update baselines for failing coverage tests.
anatoliykmetyuk
force-pushed
the
scoverage-erasure
branch
from
February 18, 2026 16:53
5a58094 to
026622a
Compare
anatoliykmetyuk
marked this pull request as ready for review
February 19, 2026 00:43
SolalPirelli
approved these changes
Feb 24, 2026
SolalPirelli
left a comment
SolalPirelli
left a comment
Contributor
There was a problem hiding this comment.
I am still new to this part of the compiler but it looks reasonable, left a suggestion
Contributor
Author
|
@Gedochao the PR is approved - could you please let me know what the process is from here to get it merged? |
Contributor
|
Tagging the reviewer after fixes are in place is generally what works 😅 |
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Mar 18, 2026
Otherwise, during erasure phase, they will be impure and emit an error. Purity constraint is needed in the context of capabilities, which are erased and can only be pure values. Enable related ignored tests. [Cherry-picked b176037][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, during erasure phase, they will be impure and emit an error. Purity constraint is needed in the context of capabilities, which are erased and can only be pure values.
Enable related ignored tests.