Accept using right associative parameters - #24766
Merged
som-snytt merged 5 commits intoMar 4, 2026
Merged
Conversation
Contributor
Author
|
This needs a tweak, as it "swaps" the implicit parameter, which is harmless but unintended. Edit: or maybe I'm misled by the way it's printed at typer. |
Contributor
|
Bump @sjrd |
sjrd
approved these changes
Mar 4, 2026
Comment on lines
+1191
to
+1192
| extParamss ++ mdef.paramss | ||
| def rightAssocParams = |
Member
There was a problem hiding this comment.
There should be a blank line here. There are blank lines within rightAssocParams. Not having a blank line here suggests that paramss match ... does not belong to rightAssocParams.
Contributor
Author
There was a problem hiding this comment.
Also applied "less fewer braces" and "indented case".
Member
|
To whoever is going to click the green button: |
som-snytt
force-pushed
the
issue/24745-right-assoc-extension
branch
from
March 4, 2026 12:00
a37f089 to
ac151e5
Compare
som-snytt
enabled auto-merge
March 4, 2026 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24745
The existing behavior is intended but unnecessarily restrictive.