Skip to content

Update IsIterable scaladoc - #24692

Merged
som-snytt merged 2 commits into
scala:mainfrom
xuwei-k:IsIterable-scaladoc-example
Feb 18, 2026
Merged

Update IsIterable scaladoc#24692
som-snytt merged 2 commits into
scala:mainfrom
xuwei-k:IsIterable-scaladoc-example

Conversation

@xuwei-k

@xuwei-k xuwei-k commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

use extension and using instead of implicit

@xuwei-k
xuwei-k requested a review from a team as a code owner December 7, 2025 11:38
@som-snytt

Copy link
Copy Markdown
Contributor

The note at the end of the section no longer applies.

@Gedochao Gedochao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamzaremmal hamzaremmal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @som-snytt's comment.

@xuwei-k
xuwei-k force-pushed the IsIterable-scaladoc-example branch from 7189b86 to 421eba4 Compare December 11, 2025 00:24
@som-snytt

Copy link
Copy Markdown
Contributor

👍

@SolalPirelli

Copy link
Copy Markdown
Contributor

@hamzaremmal now that @som-snytt is happy, are you too?

@Gedochao
Gedochao requested a review from hamzaremmal February 17, 2026 15:02
@som-snytt

som-snytt commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

"Happy" may be an exaggeration. It collided with the big docs tweak. I could try to refresh it. I have to wait for the kitchen to be free before I can make my next coffee.

Edit: There are more stale words in the extensive doc about extensions, which I will address when I have had coffee.

use `extension` and `using` instead of `implicit`
@som-snytt
som-snytt force-pushed the IsIterable-scaladoc-example branch from 421eba4 to 9eb4d43 Compare February 18, 2026 17:00
@som-snytt
som-snytt force-pushed the IsIterable-scaladoc-example branch from 9eb4d43 to 09c9eea Compare February 18, 2026 17:03
@som-snytt

Copy link
Copy Markdown
Contributor

I pushed additional edits in a second commit. It excises some words about implicit classes and conversions, including some excess words. I tried not to add excess words. I compiled the snippet and clarified some details, such as where IsIterable[Range] comes from.

@som-snytt
som-snytt merged commit e422b49 into scala:main Feb 18, 2026
60 checks passed
@WojciechMazur WojciechMazur added this to the 3.8.4 milestone Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants