Better refinement symbols in semanticDB - #18604
Merged
Merged
Conversation
Gedochao
added
the
stat: stale PR
Contributor
|
@tanishiking @rochala @natsukagami is this still relevant? Do you mean to work on this in the near future, or should we close it? |
Contributor
It does still seem relevant, we would have to rebase an make sure it all still passes. I will take a look |
tgodzik
force-pushed
the
semanticdb-refl
branch
3 times, most recently
from
February 17, 2026 19:13
9652846 to
a66dd3e
Compare
Gedochao
force-pushed
the
semanticdb-refl
branch
from
February 18, 2026 07:59
a66dd3e to
938a6af
Compare
Contributor
|
Rebased again, since #25296 would likely fix the CI failure. |
tgodzik
reviewed
Feb 18, 2026
| val s/*<-advanced::Test.s.*/ = new Structural/*->advanced::Structural#*/ | ||
| val s1/*<-advanced::Test.s1.*/ = s/*->advanced::Test.s.*/.s1/*->advanced::Structural#s1().*/ | ||
| val s1x/*<-advanced::Test.s1x.*/ = s/*->advanced::Test.s.*/.s1/*->advanced::Structural#s1().*/.x/*->scala::reflect::Selectable#selectDynamic().*/ | ||
| val s1x/*<-advanced::Test.s1x.*/ = s/*->advanced::Test.s.*/.s1/*->advanced::Structural#s1().*/.x/*->local13*/ |
Contributor
There was a problem hiding this comment.
This change might be unexpected, but the issue is that we don't have a way to represent a member of a type that is defined as result of the method. We should do a follow up for this. Maybe go the route of parameters?
Previosuly all `Select` on refined types have had symbol from `reflect.Selectable` and their definitions were not global. This change should improve navigation and rename in Metals and allow further changes in presentation compiler module, in order to provide better highlighting and hover
tgodzik
force-pushed
the
semanticdb-refl
branch
from
February 18, 2026 10:21
938a6af to
0ddde96
Compare
tgodzik
marked this pull request as ready for review
February 18, 2026 10:21
Contributor
|
Ok., this is ready to review. I think this is an overall improvement, though there might be some things to improve later on still. |
natsukagami
approved these changes
Feb 18, 2026
tgodzik
enabled auto-merge (squash)
February 18, 2026 12:01
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Feb 26, 2026
Previosuly all `Select` on refined types have had symbol from `reflect.Selectable` and their definitions were not global. This change should improve navigation and rename in Metals and allow further changes in presentation compiler module, in order to provide better highlighting and hover --------- Co-authored-by: Jakub Ciesluk <323892@uwr.edu.pl> Co-authored-by: Tomasz Godzik <tgodzik@virtuslab.com> [Cherry-picked f33c7d4][modified]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previosuly all
Selecton refined types have had symbol fromreflect.Selectableand their definitions were not global. This change should improve navigation and rename in Metals and allow further changes in presentation compiler module, in order to provide better highlighting and hover