Skip to content

Fix crash when setting keybind - #85

Merged
robiot merged 1 commit into
masterfrom
fix/g_idle_add_once
Sep 29, 2023
Merged

robiot merged 1 commit into
masterfrom
fix/g_idle_add_once

Conversation

@robiot

@robiot robiot commented Sep 28, 2023 •

Copy link
Copy Markdown
Owner

Closes #83
possibly also closes #82, #68
I am not on a linux system rn so I cant test but I will try to remember to check when I can.

@robiot

robiot commented Sep 28, 2023

Copy link
Copy Markdown
Owner Author

Yup this seems to have fixed the issue, at least for me. @UrsoTriangularo or @Shringe, could you test if it works on your machine, then I can merge and release?

@robiot robiot changed the title Possibly fix crash when setting keybind Fix crash when setting keybind Sep 28, 2023
@Shringe

Shringe commented Sep 28, 2023

Copy link
Copy Markdown

I can test later today and verify.

@Shringe

Shringe commented Sep 29, 2023

Copy link
Copy Markdown

@robiot how do I build the nightly with this commit? I have cloned the fix/g_idle_add_once branch and ran make release, but the following executable in ./build/release/src/xclicker still crashes when setting hotkey. I assume that was the stable branch and there is some way to build nightly with the commit in place, akin to some form of make nightly?

@robiot

robiot commented Sep 29, 2023

Copy link
Copy Markdown
Owner Author

@Shringe Hmm very strange, make sure to clone, run git checkout fix/g_idle_add_once then make all. Let me know if that worked.

@Shringe

Shringe commented Sep 29, 2023

Copy link
Copy Markdown

Yep, make all was it not make release, seems to work completely fine now.

@robiot

robiot commented Sep 29, 2023

Copy link
Copy Markdown
Owner Author

Ok perfect! Thanks for testing it out!

@robiot
robiot merged commit 9cf26be into master Sep 29, 2023
@robiot
robiot deleted the fix/g_idle_add_once branch September 29, 2023 09:20
@robiot robiot mentioned this pull request Sep 29, 2023
robiot added a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when setting the hotkey Key still in use after exit

2 participants